fix: bug-fix sweep across node, audio, render, plugin subsystems
Node core: - MathNode/TrigonometryNode combo strings realigned with Operation enums - mathbase scalar/vector operand pick no longer uses bitwise type checks - NodeSetPositionAndDependenciesRecursively moves dependencies again - RemoveAllKeyframes undo actually restores keyframes - NodeGroup GetInputName null-deref guard, passthrough ids use input id - NodeValueTable::Has is an exact type match; tag fallback only for empty tags; kStrCombo/kPushButton get data type names - delete_all_keyframes no longer loops forever on unparented keyframes; keyframe-load failures propagate; rational interpolation falls back to double; OpacityEffect no longer leaks its internal MathNode Audio/footage: - AudioVisualWaveform: GetSummaryFromTime underflow OOB read, TrimIn prepend length bookkeeping, OverwriteSums source channel indexing - PanNode inserts the pan value into the sample job (keyframed pan works); OutputParamsChanged is emitted on device change; PortAudio device indices are validated before Pa_GetDeviceInfo - Footage: AdjustTimeByLoopMode no longer hangs/UBs on degenerate lengths, GetStreamIndex bounds-checked, CheckFootage clears stale state on missing files, failed probes are not cached, FootageDescription::Load requires its own root element Render/track: - ViewerOutput pushes the tagged samples value; TrackList disconnects the track-height lambda; GetTrackFromReference validity check - RenderManager dummy backend: null-initialized threads, guarded decoder-cache/timer paths; Renderer::Destroy releases color cache shaders/textures; unknown dynamic backends no longer alias to oakgl - SharedMemoryRegion POSIX attach validates segment size; ReadMessage skips blank lines instead of failing; GC counter clamped; IsRenderingCustomRange implemented; TimeOffsetNode gets a true inverse OutputTimeAdjustment; zero-speed clips return the held frame Plugin/nodes: - OliveClip: stored default region of definition is honored, on-demand images are cached; OliveHost sets host identity properties and logs instead of showing modal dialogs offscreen; Plugin.h dead decls gone - DespillNode guards graph-less use with Rec.709 fallback; description typos fixed (despill, swirl); mosaic applies when only one axis matches; Windows-only Project filename separator test fixed
This commit is contained in:
@@ -243,8 +243,15 @@ TEST_F(NodeUndoTest, SetPositionCommandRestoresPreviousPosition)
|
||||
|
||||
TEST_F(NodeUndoTest, SetPositionAndDependenciesRecursivelyMovesNode)
|
||||
{
|
||||
auto *dep = AddNode<olive::MathNode>();
|
||||
auto *node = AddNode<olive::MathNode>();
|
||||
auto *context = AddNode<olive::Folder>();
|
||||
|
||||
olive::Node::ConnectEdge(
|
||||
dep, olive::NodeInput(node, olive::MathNode::kParamAIn));
|
||||
|
||||
context->SetNodePositionInContext(
|
||||
dep, olive::Node::Position(QPointF(1.0, 1.0)));
|
||||
context->SetNodePositionInContext(
|
||||
node, olive::Node::Position(QPointF(2.0, 3.0)));
|
||||
|
||||
@@ -253,9 +260,12 @@ TEST_F(NodeUndoTest, SetPositionAndDependenciesRecursivelyMovesNode)
|
||||
|
||||
cmd.redo_now();
|
||||
EXPECT_EQ(context->GetNodePositionInContext(node), QPointF(8.0, 9.0));
|
||||
// The dependency moves by the same delta as the node
|
||||
EXPECT_EQ(context->GetNodePositionInContext(dep), QPointF(7.0, 7.0));
|
||||
|
||||
cmd.undo_now();
|
||||
EXPECT_EQ(context->GetNodePositionInContext(node), QPointF(2.0, 3.0));
|
||||
EXPECT_EQ(context->GetNodePositionInContext(dep), QPointF(1.0, 1.0));
|
||||
}
|
||||
|
||||
TEST_F(NodeUndoTest, RemovePositionFromContextCommandRestoresPosition)
|
||||
@@ -909,4 +919,12 @@ TEST_F(NodeUndoTest, ImmediateRemoveAllKeyframesCommandRemovesKeys)
|
||||
EXPECT_TRUE(immediate->keyframe_tracks().at(0).isEmpty());
|
||||
EXPECT_NE(key_a->parent(), node);
|
||||
EXPECT_NE(key_b->parent(), node);
|
||||
|
||||
cmd.undo_now();
|
||||
// Undo restores the keyframes to the node and its tracks
|
||||
ASSERT_EQ(immediate->keyframe_tracks().at(0).size(), 2);
|
||||
EXPECT_EQ(immediate->keyframe_tracks().at(0).at(0), key_a);
|
||||
EXPECT_EQ(immediate->keyframe_tracks().at(0).at(1), key_b);
|
||||
EXPECT_EQ(key_a->parent(), node);
|
||||
EXPECT_EQ(key_b->parent(), node);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user