fix: bug-fix sweep across node, audio, render, plugin subsystems
Node core: - MathNode/TrigonometryNode combo strings realigned with Operation enums - mathbase scalar/vector operand pick no longer uses bitwise type checks - NodeSetPositionAndDependenciesRecursively moves dependencies again - RemoveAllKeyframes undo actually restores keyframes - NodeGroup GetInputName null-deref guard, passthrough ids use input id - NodeValueTable::Has is an exact type match; tag fallback only for empty tags; kStrCombo/kPushButton get data type names - delete_all_keyframes no longer loops forever on unparented keyframes; keyframe-load failures propagate; rational interpolation falls back to double; OpacityEffect no longer leaks its internal MathNode Audio/footage: - AudioVisualWaveform: GetSummaryFromTime underflow OOB read, TrimIn prepend length bookkeeping, OverwriteSums source channel indexing - PanNode inserts the pan value into the sample job (keyframed pan works); OutputParamsChanged is emitted on device change; PortAudio device indices are validated before Pa_GetDeviceInfo - Footage: AdjustTimeByLoopMode no longer hangs/UBs on degenerate lengths, GetStreamIndex bounds-checked, CheckFootage clears stale state on missing files, failed probes are not cached, FootageDescription::Load requires its own root element Render/track: - ViewerOutput pushes the tagged samples value; TrackList disconnects the track-height lambda; GetTrackFromReference validity check - RenderManager dummy backend: null-initialized threads, guarded decoder-cache/timer paths; Renderer::Destroy releases color cache shaders/textures; unknown dynamic backends no longer alias to oakgl - SharedMemoryRegion POSIX attach validates segment size; ReadMessage skips blank lines instead of failing; GC counter clamped; IsRenderingCustomRange implemented; TimeOffsetNode gets a true inverse OutputTimeAdjustment; zero-speed clips return the held frame Plugin/nodes: - OliveClip: stored default region of definition is honored, on-demand images are cached; OliveHost sets host identity properties and logs instead of showing modal dialogs offscreen; Plugin.h dead decls gone - DespillNode guards graph-less use with Rec.709 fallback; description typos fixed (despill, swirl); mosaic applies when only one axis matches; Windows-only Project filename separator test fixed
This commit is contained in:
@@ -364,7 +364,7 @@ TEST(PanNode, NoSamplesInputProducesNoOutput)
|
||||
olive::NodeValue::kNone);
|
||||
}
|
||||
|
||||
TEST(PanNode, KeyframedPanProducesSampleJobButLosesPanValue)
|
||||
TEST(PanNode, KeyframedPanProducesSampleJobWithPanValue)
|
||||
{
|
||||
olive::ColorManager::SetUpDefaultConfig();
|
||||
olive::Project project;
|
||||
@@ -383,22 +383,22 @@ TEST(PanNode, KeyframedPanProducesSampleJobButLosesPanValue)
|
||||
ASSERT_EQ(result.type(), olive::NodeValue::kSamples);
|
||||
ASSERT_TRUE(result.canConvert<olive::SampleJob>());
|
||||
|
||||
// NOTE: Unlike VolumeNode, PanNode::Value() never inserts the panning
|
||||
// value into the SampleJob, so the job's value map is empty and
|
||||
// ProcessSamples() always sees a pan of 0 (a plain copy). The production
|
||||
// RenderProcessor only re-evaluates inputs present in the job, so
|
||||
// keyframed pan is silently ignored (suspected bug, documented here).
|
||||
// Like VolumeNode, PanNode::Value() inserts the panning value into the
|
||||
// SampleJob so ProcessSamples() sees the keyframed pan
|
||||
const olive::SampleJob job = result.value<olive::SampleJob>();
|
||||
EXPECT_FALSE(job.GetValues().contains(olive::PanNode::kPanningInput));
|
||||
ASSERT_TRUE(job.GetValues().contains(olive::PanNode::kPanningInput));
|
||||
EXPECT_DOUBLE_EQ(job.GetValues().value(olive::PanNode::kPanningInput).toDouble(),
|
||||
1.0);
|
||||
|
||||
SampleResolvingTraverser resolver;
|
||||
resolver.Resolve(result);
|
||||
|
||||
// Pan 1.0 (full right) silences the left channel and leaves the right
|
||||
const olive::core::SampleBuffer out = result.toSamples();
|
||||
ASSERT_TRUE(out.is_allocated());
|
||||
ASSERT_EQ(out.sample_count(), 4u);
|
||||
for (int i = 0; i < 4; i++) {
|
||||
EXPECT_FLOAT_EQ(out.data(0)[i], float(i + 1));
|
||||
EXPECT_FLOAT_EQ(out.data(0)[i], 0.0f);
|
||||
EXPECT_FLOAT_EQ(out.data(1)[i], float(i + 5));
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user