fix: bug-fix sweep across node, audio, render, plugin subsystems

Node core:
- MathNode/TrigonometryNode combo strings realigned with Operation enums
- mathbase scalar/vector operand pick no longer uses bitwise type checks
- NodeSetPositionAndDependenciesRecursively moves dependencies again
- RemoveAllKeyframes undo actually restores keyframes
- NodeGroup GetInputName null-deref guard, passthrough ids use input id
- NodeValueTable::Has is an exact type match; tag fallback only for
  empty tags; kStrCombo/kPushButton get data type names
- delete_all_keyframes no longer loops forever on unparented keyframes;
  keyframe-load failures propagate; rational interpolation falls back to
  double; OpacityEffect no longer leaks its internal MathNode

Audio/footage:
- AudioVisualWaveform: GetSummaryFromTime underflow OOB read, TrimIn
  prepend length bookkeeping, OverwriteSums source channel indexing
- PanNode inserts the pan value into the sample job (keyframed pan
  works); OutputParamsChanged is emitted on device change; PortAudio
  device indices are validated before Pa_GetDeviceInfo
- Footage: AdjustTimeByLoopMode no longer hangs/UBs on degenerate
  lengths, GetStreamIndex bounds-checked, CheckFootage clears stale
  state on missing files, failed probes are not cached,
  FootageDescription::Load requires its own root element

Render/track:
- ViewerOutput pushes the tagged samples value; TrackList disconnects
  the track-height lambda; GetTrackFromReference validity check
- RenderManager dummy backend: null-initialized threads, guarded
  decoder-cache/timer paths; Renderer::Destroy releases color cache
  shaders/textures; unknown dynamic backends no longer alias to oakgl
- SharedMemoryRegion POSIX attach validates segment size; ReadMessage
  skips blank lines instead of failing; GC counter clamped;
  IsRenderingCustomRange implemented; TimeOffsetNode gets a true
  inverse OutputTimeAdjustment; zero-speed clips return the held frame

Plugin/nodes:
- OliveClip: stored default region of definition is honored, on-demand
  images are cached; OliveHost sets host identity properties and logs
  instead of showing modal dialogs offscreen; Plugin.h dead decls gone
- DespillNode guards graph-less use with Rec.709 fallback; description
  typos fixed (despill, swirl); mosaic applies when only one axis
  matches; Windows-only Project filename separator test fixed
This commit is contained in:
2026-07-17 08:26:48 +08:00
parent d9a4e27045
commit 2aa921b215
61 changed files with 731 additions and 254 deletions
+12
View File
@@ -467,7 +467,14 @@ olive::plugin::OliveClipInstance::getImage(OfxTime time,
return nullptr;
}
// Cache the on-demand image like the output path does, so repeated
// fetches at the same time reuse it and getConnected() reflects it.
// The extra reference keeps the cached image alive when the plugin
// releases its own.
pruneImagesCache();
Image *image = new Image(*this, preferred_params, bounds, rod, true);
images_.insert(time, image);
image->addReference();
return image;
}
}
@@ -546,6 +553,11 @@ olive::plugin::OliveClipInstance::getRegionOfDefinition(OfxTime time) const
double par = params_.pixel_aspect_ratio().toDouble();
regionOfDefinition.x2 = params_.width() * par;
regionOfDefinition.y2 = params_.height();
if (regionOfDefinition.x2 <= 0 || regionOfDefinition.y2 <= 0) {
// The params provide no usable region; fall back to the default set
// via setDefaultRegionOfDefinition().
return defaultRegionOfDefinitions_;
}
return regionOfDefinition;
}
void olive::plugin::OliveClipInstance::setRegionOfDefinition(
+44 -4
View File
@@ -33,6 +33,7 @@
#include "OlivePluginInstance.h"
#include "common/Current.h"
#include "ofxMessage.h"
#include "version.h"
#include <QMessageBox>
using namespace OFX::Host;
using namespace olive::plugin;
@@ -113,6 +114,26 @@ void olive::plugin::loadPlugins(QString path)
}
cache->scanPluginFiles();
}
OliveHost::OliveHost()
{
// Identify the host to plugins; HostSupport seeds these with "UNKNOWN".
_properties.setStringProperty(kOfxPropName, "Oak Video Editor");
_properties.setStringProperty(kOfxPropLabel, "Oak Video Editor");
_properties.setStringProperty(kOfxPropVersionLabel,
olive::kAppVersion.toStdString());
// Numeric version for plugins that query kOfxPropVersion directly.
const QStringList version_parts =
olive::kAppVersion.section(QLatin1Char('-'), 0, 0)
.split(QLatin1Char('.'));
_properties.setIntProperty(kOfxPropVersion,
version_parts.value(0).toInt(), 0);
_properties.setIntProperty(kOfxPropVersion,
version_parts.value(1).toInt(), 1);
_properties.setIntProperty(kOfxPropVersion,
version_parts.value(2).toInt(), 2);
}
OliveHost::~OliveHost()
{
}
@@ -184,7 +205,9 @@ OfxStatus olive::plugin::OliveHost::vmessage(const char *type, const char *id,
QString message(buffer);
auto *app = qobject_cast<QApplication *>(QCoreApplication::instance());
if (!app) {
// A modal dialog would hang a headless (offscreen) session, so log to
// stderr instead of showing one.
if (!app || QGuiApplication::platformName() == QLatin1String("offscreen")) {
qWarning().noquote() << "OFX message:" << type << message;
if (strcmp(type, kOfxMessageQuestion) == 0) {
return kOfxStatReplyNo;
@@ -223,15 +246,32 @@ OfxStatus olive::plugin::OliveHost::setPersistentMessage(const char *type,
vsnprintf(buffer, sizeof(buffer), format, args);
QString message(buffer);
// A modal dialog would hang a headless (offscreen) session, so log to
// stderr instead of showing one.
const bool headless =
QGuiApplication::platformName() == QLatin1String("offscreen");
if (strcmp(type, kOfxMessageError) == 0) {
persistent_messages_.append({ HostMessageType::Error, message });
QMessageBox::critical(nullptr, "", message);
if (headless) {
qWarning().noquote() << "OFX error:" << message;
} else {
QMessageBox::critical(nullptr, "", message);
}
} else if (strcmp(type, kOfxMessageWarning) == 0) {
persistent_messages_.append({ HostMessageType::Warning, message });
QMessageBox::warning(nullptr, "", message);
if (headless) {
qWarning().noquote() << "OFX warning:" << message;
} else {
QMessageBox::warning(nullptr, "", message);
}
} else if (strcmp(type, kOfxMessageMessage) == 0) {
persistent_messages_.append({ HostMessageType::Message, message });
QMessageBox::information(nullptr, "", message);
if (headless) {
qWarning().noquote() << "OFX message:" << message;
} else {
QMessageBox::information(nullptr, "", message);
}
} else {
return kOfxStatFailed;
}
+1 -1
View File
@@ -44,7 +44,7 @@ struct HostPersistentMessage {
void loadPlugins(QString path);
class OliveHost : public OFX::Host::ImageEffect::Host {
public:
OliveHost() = default;
OliveHost();
~OliveHost() override;
void destroyInstance(OFX::Host::ImageEffect::Instance *instance);