rational: use true min/max values for extended range

Will address issues caused by comparisons to our MIN/MAX constants when a numerator/denominator is > INT32_MAX/MIN.
2020-06-01 17:44:42 +10:00
parent 644fb7cec8
commit 1301d4b9cf
2 changed files with 26 additions and 3 deletions
@@ -229,6 +229,18 @@ bool rational::operator<(const rational &rhs) const
    return false;
  }

+  if (rhs == RATIONAL_MAX
+      || *this == RATIONAL_MIN) {
+    // We will always wither be LESS THAN (true) or EQUAL (false)
+    return (*this != rhs);
+  }
+
+  if (*this == RATIONAL_MAX
+      || rhs == RATIONAL_MIN) {
+    // We will always be GREATER THAN (false) or EQUAL (false)
+    return false;
+  }
+
  if (!isNull() && rhs.isNull()) {
    return (numer_ * denom_ < intType(0));
  }
@@ -246,6 +258,18 @@ bool rational::operator<=(const rational &rhs) const
    return true;
  }

+  if (rhs == RATIONAL_MAX
+      || *this == RATIONAL_MIN) {
+    // We will always wither be LESS THAN (true) or EQUAL (true)
+    return true;
+  }
+
+  if (*this == RATIONAL_MAX
+      || rhs == RATIONAL_MIN) {
+    // We will always be GREATER THAN (false) or EQUAL (true)
+    return rhs == *this;
+  }
+
  if (!isNull() && rhs.isNull()) {
    return (numer_ * denom_ < intType(0));
  }