From 017271b90900ac807b4480b0b38852d31fac3dde Mon Sep 17 00:00:00 2001 From: itsmattkc Date: Mon, 1 Jun 2020 04:45:45 +1000 Subject: [PATCH] cachetask: write silence if no samples are returned Fixes segfault trying to access a null sample buffer. --- app/task/cache/cache.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/app/task/cache/cache.cpp b/app/task/cache/cache.cpp index dae6329e3..b2f054b1c 100644 --- a/app/task/cache/cache.cpp +++ b/app/task/cache/cache.cpp @@ -71,7 +71,11 @@ void CacheTask::FrameDownloaded(const QByteArray &hash, const std::listaudio_playback_cache()->WritePCM(range, samples); + if (samples) { + viewer()->audio_playback_cache()->WritePCM(range, samples); + } else { + viewer()->audio_playback_cache()->WriteSilence(range); + } } OLIVE_NAMESPACE_EXIT